URL in "mutt -v" output

[Vincent Lefevre]

The "mutt -v" output contains:

To report a bug, please visit https://gitlab.com/muttmua/mutt/issues.

However the URL (e.g. obtained with copy-paste)

https://gitlab.com/muttmua/mutt/issues.

yields a 404 error. I think that it would be better to write:

To report a bug, please visit <https://gitlab.com/muttmua/mutt/issues>.

[Patrick Shanahan]

Post by Vincent Lefevre
To report a bug, please visit https://gitlab.com/muttmua/mutt/issues.
However the URL (e.g. obtained with copy-paste)
https://gitlab.com/muttmua/mutt/issues.
To report a bug, please visit <https://gitlab.com/muttmua/mutt/issues>.

humm, works as expected on my openSUSE Tumbleweed. the dot is not copied
with copy/paste nor included if I select to open the url.

have you possibly altered your selection criteria?

[Kevin J. McCarthy]

Post by Patrick Shanahan

Post by Vincent Lefevre
To report a bug, please visit https://gitlab.com/muttmua/mutt/issues.
However the URL (e.g. obtained with copy-paste)
https://gitlab.com/muttmua/mutt/issues.
To report a bug, please visit <https://gitlab.com/muttmua/mutt/issues>.

humm, works as expected on my openSUSE Tumbleweed. the dot is not copied
with copy/paste nor included if I select to open the url.
have you possibly altered your selection criteria?

I think Vincent meant that it's easy to inadvertantly select the
period now. Previously the URL was http://bugs.mutt.org/ so it was more
obvious that the period punctation wasn't a part of the URL.

On the other hand, urxvt and gnome-terminal both select the URL
properly, and I don't believe it's ambiguous. Is this really worth
changing along with all the po files?

[Derek Martin]

Post by Kevin J. McCarthy
I think Vincent meant that it's easy to inadvertantly select the
period now. Previously the URL was http://bugs.mutt.org/ so it was more
obvious that the period punctation wasn't a part of the URL.

Moreover, as written, the period IS part of the URL, and it is valid
in a URL.

Post by Kevin J. McCarthy
On the other hand, urxvt and gnome-terminal both select the URL
properly, and I don't believe it's ambiguous.

My gnome-terminal includes the '.' character.

Post by Kevin J. McCarthy
Is this really worth changing along with all the po files?

I think it is. I think for clarity, it would actually be better
written like this:

To report a bug, please contact the Mutt maintainers via gitlab:

https://gitlab.com/muttmua/mutt/issues

So written, there can be no ambiguity for softare or humans.

[Kevin J. McCarthy]

Post by Derek Martin

Post by Kevin J. McCarthy
On the other hand, urxvt and gnome-terminal both select the URL
properly, and I don't believe it's ambiguous.

My gnome-terminal includes the '.' character.

Okay, I'll make the change then. I'd prefer Vincent's suggestion
though, because it flows better with the surrounding text in `mutt -v`,
and it's a lot easier to make the change across all the files.

[Vincent Lefevre]

Post by Kevin J. McCarthy

Post by Derek Martin

Post by Kevin J. McCarthy
On the other hand, urxvt and gnome-terminal both select the URL
properly, and I don't believe it's ambiguous.

My gnome-terminal includes the '.' character.

Okay, I'll make the change then. I'd prefer Vincent's suggestion
though, because it flows better with the surrounding text in `mutt -v`,
and it's a lot easier to make the change across all the files.

The URL on a separate line as suggested by Derek may be better
for translations (at least the French one), for which the text
is longer, so that it fits on 80 columns.

[Kevin J. McCarthy]

Post by Vincent Lefevre

Post by Kevin J. McCarthy

Post by Derek Martin

Post by Kevin J. McCarthy
On the other hand, urxvt and gnome-terminal both select the URL
properly, and I don't believe it's ambiguous.

My gnome-terminal includes the '.' character.

Okay, I'll make the change then. I'd prefer Vincent's suggestion
though, because it flows better with the surrounding text in `mutt -v`,
and it's a lot easier to make the change across all the files.

The URL on a separate line as suggested by Derek may be better
for translations (at least the French one), for which the text
is longer, so that it fits on 80 columns.

As a compromise, I will add the <> delimiters in the stable branch, so
it can be included in the next stable release without requiring
translator updates.

Derek's suggestion requires some word changes that will need translator
updates. I'll post a patch here for that change, and when we all agree,
will commit that to the master branch.

[Kevin J. McCarthy]

Post by Kevin J. McCarthy
Derek's suggestion requires some word changes that will need translator
updates. I'll post a patch here for that change, and when we all agree,
will commit that to the master branch.

Attached is a patch to master with the suggested change. I would
suggest applying it and looking at the output of `mutt -v` and `mutt
-vv`.

It may also be useful to look at some of the translation files. Some of
them have rearranged the sentence order, such as ca.po, da.po, es.po,
eu.po, hu.po, ja.po, etc.

I'd appreciate feedback about how the revised sentence structure would
affect those translations, if anyone can comment.

[Derek Martin]

Post by Kevin J. McCarthy
Derek's suggestion requires some word changes that will need translator
updates. I'll post a patch here for that change, and when we all agree,
will commit that to the master branch.

FWIW, I chose that exact formatting because it completely obviates the
need for any extraneous (non-URL) characters near the URL itself. It
is unambiguous and does not beg for grammatical adornments or visual
separators, which might trip up either the human user or the user's
software. I doubt the difference really warrants even the amount of
discussion we've already had about it... ;-)

[Kevin J. McCarthy]

Post by Derek Martin

Post by Kevin J. McCarthy
Derek's suggestion requires some word changes that will need translator
updates. I'll post a patch here for that change, and when we all agree,
will commit that to the master branch.

FWIW, I chose that exact formatting because it completely obviates the
need for any extraneous (non-URL) characters near the URL itself. It
is unambiguous and does not beg for grammatical adornments or visual
separators, which might trip up either the human user or the user's
software. I doubt the difference really warrants even the amount of
discussion we've already had about it... ;-)

Well, I appreciate your feedback and suggestions. If you and Vincent
can find a version you like, I'm happy to commit that. :-)

[Vincent Lefevre]

Post by Kevin J. McCarthy
Well, I appreciate your feedback and suggestions. If you and Vincent
can find a version you like, I'm happy to commit that. :-)

I have'nt tried, but isn't there a missing \n at the end?

static const char *ReachingUs = N_("\
To contact the developers, please mail to <mutt-***@mutt.org>.\n\
-To report a bug, please visit <https://gitlab.com/muttmua/mutt/issues>.\n");
+To report a bug, please contact the Mutt maintainers via gitlab:\n\
+ https://gitlab.com/muttmua/mutt/issues");

Otherwise, this looks OK and would improve the French version.

[Kevin J. McCarthy]

Post by Vincent Lefevre

Post by Kevin J. McCarthy
Well, I appreciate your feedback and suggestions. If you and Vincent
can find a version you like, I'm happy to commit that. :-)

I have'nt tried, but isn't there a missing \n at the end?
static const char *ReachingUs = N_("\
-To report a bug, please visit <https://gitlab.com/muttmua/mutt/issues>.\n");
+To report a bug, please contact the Mutt maintainers via gitlab:\n\
+ https://gitlab.com/muttmua/mutt/issues");
Otherwise, this looks OK and would improve the French version.

Yes, sorry I didn't try the patch either. There should be a \n on the
last line too. If this looks okay to you, I'll push it up (with the
extra missing \n) later on today.